Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NL: misc fulfillment fixes #2923

Merged
merged 1 commit into from
Jul 12, 2023
Merged

NL: misc fulfillment fixes #2923

merged 1 commit into from
Jul 12, 2023

Conversation

pradh
Copy link
Contributor

@pradh pradh commented Jul 12, 2023

1 - Handle mixed fallbacks better

If we retrieve a place or variable from context and also do place fallback, provide a unified message.

Before this PR we would not report place fallback when we fallback from a place in context. [asthma in california] -> [what about blood pressure?]

Now we'll say, Tried looking up relevant statistics for "California" based on your prior queries, but found no results. Here are results for "United States" instead.

2 - Avoid duplicate SVs in comparison bar charts

[How long do workers in Maryland live] from earlier today

3 - Avoid bar charts that have no SV in title

image

These come about because we were expanding a "main SV" even when it doesn't pass existing check, so fix that.

4 - Add fallback info debug page

image

5 - Exclude more per-capita SVs

This is a temporary thing until we have chart controls for per-capita.

@pradh pradh requested review from shifucun and jehangiramjad July 12, 2023 03:41
@pradh pradh merged commit 72d91fe into datacommonsorg:master Jul 12, 2023
pradh added a commit that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants