Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a simple client to the DC resolution APIs. #204

Merged
merged 1 commit into from
Jul 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@ To build binary: `mvn package`
java -jar tool/target/datacommons-import-tool-0.1-alpha.1-jar-with-dependencies.jar
```

> To run the above maven commands on M1 macs ([details][m1]), use the `-Dos.arch=x86_64` option.
>
> e.g. `mvn compile -Dos.arch=x86_64`
[m1]: https://github.com/os72/protoc-jar/pull/94#issuecomment-1271505497

### Run Server

The repo also hosts an experimental server for private DC.
Expand Down
10 changes: 10 additions & 0 deletions tool/src/test/java/org/datacommons/tool/GenMcfTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.Set;
import org.apache.commons.io.FilenameUtils;
import org.datacommons.util.LogWrapper;
import org.datacommons.util.SummaryReportGenerator;
Expand Down Expand Up @@ -61,6 +62,11 @@ public class GenMcfTest {
"localidresolution", 5,
"manyinconsistent", 4);

// Skip testing the following files. If this List is non-empty, the flaky files should be fixed
keyurva marked this conversation as resolved.
Show resolved Hide resolved
// and removed from this list.
// TODO: Fix the flaky "successtmcf" test.
private static Set<String> SKIP_FLAKY_FILES = Set.of("successtmcf");

private static final String ARGS_TXT_FNAME = "args.txt";

@Test
Expand All @@ -76,6 +82,10 @@ public void GenMcfTest() throws IOException {
File[] testDirectories = new File(resourceFile("genmcf")).listFiles(File::isDirectory);
for (File directory : testDirectories) {
String testName = directory.getName();
if (SKIP_FLAKY_FILES.contains(testName)) {
System.err.printf("SKIPPING FLAKY FILE: %s\n", testName);
continue;
}
System.err.println(testName + ": BEGIN");
assertTrue(EXPECTED_FILES_TO_CHECK.containsKey(testName));
List<String> argsList = new ArrayList<>();
Expand Down
Loading