Skip to content

Commit

Permalink
Remove Java checks from new push trigger config (#328)
Browse files Browse the repository at this point in the history
The current trigger (using config cloudbuild.java.yaml) runs on branches other than master as well. Since Java checks already run on presubmit, I am removing them from this trigger's config which runs post-submit. When editing the import-push-java trigger, I'll also change it to run only on pushes to master.
  • Loading branch information
hqpho authored Jun 28, 2024
1 parent 9c1287e commit 69b0e58
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions build/ci/cloudbuild.push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# Cloud build config that is triggered on a push to master.
# This cloud build is triggered when there is code change, but can also involve
# data change.

Expand All @@ -29,10 +30,3 @@ steps:
cd /tmp/deployment
./scripts/update_external_repo_version.sh $REPO_NAME $SHORT_SHA
waitFor: ["-"]

# Generate protoc, build, check-format and run test
- id: "format & test"
name: "maven:3-jdk-11"
entrypoint: "mvn"
args: ["com.spotify.fmt:fmt-maven-plugin:check", "test"]
waitFor: ["-"]

0 comments on commit 69b0e58

Please sign in to comment.