-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Initial Folder Structure for Data Commons Client #202
base: master
Are you sure you want to change the base?
Add Initial Folder Structure for Data Commons Client #202
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the initial pull request! I've updated the cloud build tests to stream output back to github, and added you both as collaborators so you shouldn't need /gcbrun to trigger tests in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jorge!
@jm-rivera you should be able to merge after addressing the CLA check (from google-cla above). please let us know if you run into any issues with that |
Adds minimal structure within a new client folder
592a7b1
to
b689f54
Compare
Thank you @beets! Our legal department signed the docusign on Friday and now it says it is waiting for approval on your side. Would you mind checking if there's something else we should do for that to come through? |
Hi @beets - we're finally covered by the CLA! So the checks are finally passing. |
This is a housekeeping PR which adds the folder structure we plan to implement, based on the design document.
The folders are empty (other than
__init__
files).We decided to put everything inside
/datacommons_client
while the DC team decides how they want to structure things with the different packages and libraries. The structure could always be refactored in the future, but this will allow us to develop in a relatively clean environment without deleting or moving things around.