Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Initial Folder Structure for Data Commons Client #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jm-rivera
Copy link

This is a housekeeping PR which adds the folder structure we plan to implement, based on the design document.
The folders are empty (other than __init__ files).

We decided to put everything inside /datacommons_client while the DC team decides how they want to structure things with the different packages and libraries. The structure could always be refactored in the future, but this will allow us to develop in a relatively clean environment without deleting or moving things around.

Copy link

google-cla bot commented Dec 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@beets beets requested a review from dwnoble December 4, 2024 23:42
@beets
Copy link
Contributor

beets commented Dec 4, 2024

/gcbrun

Copy link
Contributor

@beets beets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initial pull request! I've updated the cloud build tests to stream output back to github, and added you both as collaborators so you shouldn't need /gcbrun to trigger tests in the future.

Copy link

@dwnoble dwnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jorge!

@beets
Copy link
Contributor

beets commented Dec 6, 2024

@jm-rivera you should be able to merge after addressing the CLA check (from google-cla above). please let us know if you run into any issues with that

@jm-rivera jm-rivera self-assigned this Dec 9, 2024
Adds minimal structure within a new client folder
@jm-rivera jm-rivera force-pushed the 13-new-package-structure branch from 592a7b1 to b689f54 Compare December 9, 2024 08:21
@jm-rivera
Copy link
Author

@jm-rivera you should be able to merge after addressing the CLA check (from google-cla above). please let us know if you run into any issues with that

Thank you @beets! Our legal department signed the docusign on Friday and now it says it is waiting for approval on your side. Would you mind checking if there's something else we should do for that to come through?

@jm-rivera
Copy link
Author

@jm-rivera you should be able to merge after addressing the CLA check (from google-cla above). please let us know if you run into any issues with that

Hi @beets - we're finally covered by the CLA! So the checks are finally passing.
What will be the process once different reviewers approve? I don't have rights to push to the master branch (so right now merging is blocked for me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants