add chunked query to dc python api #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding conduct_chunked_query and its helper function recursive_query to be able to conduct large queries without overloading Data Commons server.
I had tried to add in the tests in chunked_query_test.py to tests/query_test.py, but was having a lot of trouble doing so. Should the tests be put in once conduct_chunked_query can be reached using just the api (as in dc.conduct_chunked_query() )?
Additionally, the test test_large_query() in chunked_query_test.py occasionally fails when running over command line, but I have run the same test many, many times using a colab notebook, and it never fails there. Any insight to why that may be happening would be appreciated :) I don't think it has to do with the code in the two functions since it works fine in colab. Maybe either the testing environment or the server, since it works fine in colab? I am not sure.
Thank you for the help!