Trim leading zeros for expected value #42
Merged
+130
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naohiro Yoshida <[email protected]>
yoshidan
changed the title
bluele
reviewed
Feb 26, 2024
light-client/src/commitment.rs
Outdated
| let expected_value = expected_value.as_ref().map(|e| rlp::encode(e).to_vec()); | ||
| let expected_value = expected_value | ||
| .as_ref() | ||
| .map(|e| rlp::encode(&trim_left_zero(e).to_vec()).to_vec()); |
There was a problem hiding this comment.
You can remove .to_vec()
.map(|e| rlp::encode(&trim_left_zero(e)).to_vec());
There was a problem hiding this comment.
Thanks. I fixed it.
bluele
reviewed
Feb 26, 2024
| let expected_value = expected_value.as_ref().map(|e| rlp::encode(e).to_vec()); | ||
| let expected_value = expected_value | ||
| .as_ref() | ||
| .map(|e| rlp::encode(&trim_left_zero(e).to_vec()).to_vec()); | ||
| if value != expected_value { | ||
| return Err(Error::UnexpectedStateValue( |
There was a problem hiding this comment.
Can you add value to UnexpectedStateValue error? It would be helpful for debug.
Signed-off-by: Naohiro Yoshida <[email protected]>
bluele
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BSC / ethereum, the leading zeros in the proof value is trimmed, so ELC also trims leading zeros.