Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy enclaveKey from tmp Dir without using os.Rename #2

Merged
merged 2 commits into from
Oct 10, 2023
Merged

copy enclaveKey from tmp Dir without using os.Rename #2

merged 2 commits into from
Oct 10, 2023
+20 −9

Conversation

toshihiko-okubo
Copy link
Member

No description provided.

@toshihiko-okubo toshihiko-okubo requested a review from bluele October 6, 2023 08:50
@bluele
Copy link
Member

bluele commented Oct 6, 2023

@toshihiko-okubo Looks like the pr contains some diff for simapp. Could you contain the minimal diff?

@toshihiko-okubo
Copy link
Member Author

@bluele
sorry, it was because the IDE autofix was executed.

bluele
bluele approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@bluele bluele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@bluele bluele merged commit a789dae into main Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluele bluele bluele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toshihiko-okubo @bluele