BEP-341 #30
Merged
BEP-341 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
May 27, 2024 19:41
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
yoshidan
changed the base branch from
remove_non_neighboring_epoch_verify
to
HF/Bohr
added 6 commits
July 23, 2024 18:20
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
yoshidan
commented
Jul 30, 2024
| func (v Validators) Checkpoint(epoch uint64) uint64 { | ||
| return epoch + v.CheckpointValue() | ||
| func (v Validators) Checkpoint(turnLength uint8) uint64 { | ||
| return uint64(len(v)/2+1) * uint64(turnLength) |
There was a problem hiding this comment.
yoshidan
commented
Jul 30, 2024
| } | ||
| num := int(extra[extraVanity]) | ||
| if num == 0 || len(extra) <= extraVanity+extraSeal+num*validatorBytesLength { | ||
| return nil, fmt.Errorf("invalid validator bytes length: %d", h.Number.Uint64()) | ||
| if num == 0 || len(extra) <= extraVanity+extraSeal+num*validatorBytesLength+turnLengthLength { |
There was a problem hiding this comment.
turnLength is located on behind the validator bytes in extra_data
https://github.com/bnb-chain/bsc/blob/00cac12542a112a4767295d948c15d7e31525eaf/consensus/parlia/parlia.go#L383
added 3 commits
July 30, 2024 11:15
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
added 2 commits
August 10, 2024 11:08
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
3100
approved these changes
Aug 14, 2024
added 2 commits
August 14, 2024 17:00
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/bnb-chain/BEPs/blob/master/BEPs/BEP-341.md