BEP126 #14
Closed
BEP126 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yoshidan <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
added 3 commits
September 13, 2023 21:57
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
3100
reviewed
Sep 15, 2023
| @@ -0,0 +1,1078 @@ | |||
| pragma solidity 0.6.4; | |||
There was a problem hiding this comment.
Please assign a license identifier:
// SPDX-License-Identifier: Apache-2.0
// Copyright 2020 All BNB Chain Developers
// Modified by Datachain, Inc. on 2023
| @@ -0,0 +1,86 @@ | |||
| pragma solidity 0.6.4; | |||
There was a problem hiding this comment.
Same as ./BSCValidatorSet.template.
|
|
||
| func getVoteAttestationFromHeader(header *types.Header) (*VoteAttestation, error) { | ||
| if len(header.Extra) <= extraVanity+extraSeal { | ||
| return nil, nil |
There was a problem hiding this comment.
Could you add a comment explaining under what circumstances this occurs?
There was a problem hiding this comment.
I added link to bsc source.
| func createMainnetProver() (*module.Prover, core.Chain, error) { | ||
| chain, err := ethereum.NewChain(ethereum.ChainConfig{ | ||
| EthChainId: 56, | ||
| RpcAddr: "https://bsc-mainnet-rpc.allthatnode.com", |
There was a problem hiding this comment.
This doesn't seem to be an official RPC. Is there a particular reason for choosing this?
Additionally, what do you think about making it configurable from the outside?
There was a problem hiding this comment.
The official node was not able to obtain account proof.
2023/09/15 16:17:46 Failed to run command : failed to get account proof : height = 31757489, failed to get account proof limit exceeded
I made RPC address configurable now.
* update lcp Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/datachainlab/docs/issues/4187