Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable receive flush on shutdown #58

Merged
merged 1 commit into from
Aug 7, 2024
Merged

disable receive flush on shutdown #58

merged 1 commit into from
Aug 7, 2024

Conversation

christopherzli
Copy link

@christopherzli christopherzli commented Jul 18, 2024 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

deployed in integration test and it worked;
rolling out to dev to observe if any data loss

@yuchen-db yuchen-db self-requested a review July 18, 2024 07:57
yuchen-db
yuchen-db approved these changes Jul 18, 2024
View reviewed changes
Copy link

@yuchen-db yuchen-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christopherzli christopherzli requested review from jnyi and hczhu-db July 20, 2024 00:32
hczhu-db
hczhu-db approved these changes Jul 20, 2024
View reviewed changes
Copy link
Collaborator

@hczhu-db hczhu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you share test results like charts, perhaps in a Universe PR?

jnyi
jnyi approved these changes Jul 20, 2024
View reviewed changes
Copy link
Collaborator

@jnyi jnyi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, +1, could test in your own branch before merging?

@christopherzli christopherzli merged commit c51fcda into db_main Aug 7, 2024
12 checks passed
@jnyi jnyi deleted the disable branch November 1, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuchen-db yuchen-db yuchen-db approved these changes

@hczhu-db hczhu-db hczhu-db approved these changes

@jnyi jnyi jnyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christopherzli @jnyi @hczhu-db @yuchen-db