Polish Thanos Receive load shedding #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hczhu-db
force-pushed
the
fix-load-shedding
branch
2 times, most recently
from
3a542ba to
f2673be
Compare
hczhu-db
changed the title
hczhu-db
force-pushed
the
fix-load-shedding
branch
from
f2673be to
209f0e8
Compare
hczhu-db
force-pushed
the
fix-load-shedding
branch
from
209f0e8 to
5438a46
Compare
jnyi
reviewed
Dec 19, 2024
| } | ||
|
|
||
| func (l *Limiter) DecrementPendingRequests() { | ||
| newValue := l.pendingRequests.Add(-1) | ||
| if l.pendingRequestsGauge != nil { |
jnyi
reviewed
Dec 19, 2024
| if l.maxPendingRequestLimitHit != nil { | ||
| l.maxPendingRequestLimitHit.Inc() | ||
| } | ||
| if l.pendingRequestsGauge != nil { |
There was a problem hiding this comment.
i think tracking pending request should always on, check nil seems unnecessary and hurts the code readability
There was a problem hiding this comment.
That's how existing instrumentation works. I believe there is a code path such that those metrics are not initiated.
yuchen-db
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add unit tests in a follow-up PR