Skip to content

Commit

Permalink
Receive: fix issue-7248 with parallel receive_forward (thanos-io#7267)
Browse files Browse the repository at this point in the history
* Receive: fix issue-7248 by introducing a worker pool

Signed-off-by: Yi Jin <[email protected]>

* fix unit test bug

Signed-off-by: Yi Jin <[email protected]>

* fix CLI flags not pass into the receive handler

Signed-off-by: Yi Jin <[email protected]>

* address comments

Signed-off-by: Yi Jin <[email protected]>

* init context in constructor

Signed-off-by: Yi Jin <[email protected]>

---------

Signed-off-by: Yi Jin <[email protected]>
  • Loading branch information
jnyi authored and hczhu-db committed Aug 22, 2024
1 parent eddbbb3 commit a646c05
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/receive/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -1440,7 +1440,8 @@ func (p *peerGroup) closeUnlocked(addr string) error {
// was never established.
return nil
}
c.wp.Close()

p.connections[addr].wp.Close()
delete(p.connections, addr)
if err := c.cc.Close(); err != nil {
return fmt.Errorf("closing connection for %s", addr)
Expand Down

0 comments on commit a646c05

Please sign in to comment.