Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter] Correctly handle DB-managed UC objects #4323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Dec 14, 2024

Changes

Databricks has started to introduce UC objects that are created and managed by Databricks, i.e., storage credentials and external locations, so we can't create resources to manage them.

This PR converts such managed UC objects into data sources so we can attach permissions to them and handle references. The change of ownership is still not implemented - filed #4321 to handle it.

Other changes include:

  • refactoring of creation of new resource data objects
  • fixing a problem with the codegen of data sources, so we don't need a dedicated Body implementation.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

Databricks has started to introduce UC objects that are created and managed by Databricks,
i.e., storage credentials and external locations, so we can't create resources to manage
them.

This PR converts such managed UC objects into data sources, so we can attach permissions
to them, and handle references.

Other changes include:

- refactoring of creation of new resource data objects
- fixing a problem with codegen of data sources, so we don't need a dedicated `Body`
  implementation.
@alexott alexott requested review from a team as code owners December 14, 2024 09:48
@alexott alexott requested review from mgyucht and removed request for a team December 14, 2024 09:48
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4323
  • Commit SHA: 1a6cbeae329dc6eb2d64b7ce9569aca0f2486203

Checks will be approved automatically on success.

@alexott alexott requested a review from tanmay-db December 14, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant