[Internal] Make Read after Create/Update configurable
#4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the ability for a resource to specify that it may not need to call `Read` after `Create` and `Update` operations so we can avoid performing another API call(s). The resource may implement `CanSkipReadAfterCreateAndUpdate` function that can decide if the `Read` operation should be skipped. I decided to move common part from #4173 to make it easier to review
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
5 tasks
mgyucht
approved these changes
Nov 4, 2024
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/11668917615 |
tanmay-db
added a commit
that referenced
this pull request
Nov 5, 2024
### New Features and Improvements * Added `databricks_functions` data source ([#4154](#4154)). ### Bug Fixes * Handle edge case for `effective_properties` in `databricks_sql_table` ([#4153](#4153)). * Provide more prescriptive error when users fail to create a single node cluster ([#4168](#4168)). ### Internal Changes * Add test instructions for external contributors ([#4169](#4169)). * Always write message for manual test integration ([#4188](#4188)). * Make `Read` after `Create`/`Update` configurable ([#4190](#4190)). * Migrate Share Data Source to Plugin Framework ([#4161](#4161)). * Migrate Share Resource to Plugin Framework ([#4047](#4047)). * Rollout Plugin Framework ([#4134](#4134)). ### Dependency Updates * Bump Go SDK to v0.50.0 ([#4178](#4178)). ### Exporter * Allow to match resource names by regular expression ([#4177](#4177)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
### New Features and Improvements * Added `databricks_functions` data source ([#4154](#4154)). ### Bug Fixes * Handle edge case for `effective_properties` in `databricks_sql_table` ([#4153](#4153)). * Provide more prescriptive error when users fail to create a single node cluster ([#4168](#4168)). ### Internal Changes * Add test instructions for external contributors ([#4169](#4169)). * Always write message for manual test integration ([#4188](#4188)). * Make `Read` after `Create`/`Update` configurable ([#4190](#4190)). * Migrate Share Data Source to Plugin Framework ([#4161](#4161)). * Migrate Share Resource to Plugin Framework ([#4047](#4047)). * Rollout Plugin Framework ([#4134](#4134)). ### Dependency Updates * Bump Go SDK to v0.50.0 ([#4178](#4178)). ### Exporter * Allow to match resource names by regular expression ([#4177](#4177)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the ability for a resource to specify that it may not need to call
ReadafterCreateandUpdateoperations so we can avoid performing another API call(s). The resource may implementCanSkipReadAfterCreateAndUpdatefunction that can decide if theReadoperation should be skipped.I decided to move common part from #4173 to make it easier to review
Tests
make testrun locallydocs/folderinternal/acceptance