-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal][Draft] Plugin Framework Rollout #4101
base: main
Are you sure you want to change the base?
Conversation
cluster.DataSourceCluster, | ||
volume.DataSourceVolumes, | ||
registered_model.DataSourceRegisteredModel, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debatable decision - do we want to have more fine grained control such that we can use different environment variable values to control specific resources / data sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, mentioning for visibility -- it would be better to have more finer grained control per resource so people can pass the resources they want to use sdkv2 for individually as otherwise they would have to use sdkv2 for all resources if there is a bug in one resource.
fdc9391
to
ae87858
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, approach seems fine. It's a bit strange to have the SDKv2 implementation depend on the pluginfw one, but I think that's an OK direction (the other way around would be problematic).
Can we make sure to update the documentation for each of these migrated resources with instructions for customers to fall-back to the original implementation?
Also, let's split migrated and non-migrated resources, since non-migrated resources should not be possible to roll-back to the original implementation.
var migratedDataSourceMap = map[string]func() datasource.DataSource{ | ||
"databricks_cluster": cluster.DataSourceCluster, | ||
"databricks_volumes": volume.DataSourceVolumes, | ||
"databricks_registered_model": registered_model.DataSourceRegisteredModel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not migrated IIUC. It should only exist in the plugin framework.
|
||
// Map of resources that have been migrated from SDK V2 to plugin framework | ||
var migratedResourceMap = map[string]func() resource.Resource{ | ||
"databricks_qualitymonitor": qualitymonitor.ResourceQualityMonitor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of hard-coding the names here, we can get them by calling the Metadata()
method for each resource/data source.
Changes
USE_SDK_V2
to control rolloutTests
make test
run locallydocs/
folderinternal/acceptance