[Fix] Add no_wait flag to databricks_online_table to avoid timeouts
#4056
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an online table from the big Delta table, waiting for full sync could take too long time, and creation timeouts. The new `no_wait` flag allows to skip wait for online table creation.
alexott
requested review from
parthban-db and
tanmay-db
and removed request for
a team
tanmay-db
approved these changes
Nov 14, 2024
| @@ -64,6 +65,16 @@ func ResourceOnlineTable() common.Resource { | |||
| runTypes := []string{"spec.0.run_triggered", "spec.0.run_continuously"} | |||
| common.CustomizeSchemaPath(m, "spec", "run_triggered").SetAtLeastOneOf(runTypes).SetSuppressDiff() | |||
| common.CustomizeSchemaPath(m, "spec", "run_continuously").SetAtLeastOneOf(runTypes).SetSuppressDiff() | |||
|
|
|||
| m["no_wait"] = &schema.Schema{ | |||
There was a problem hiding this comment.
Curious -- how useful would this be? My understanding is that it would fail most of the times if waiting for online table creation takes a few minutes. But if this helps some use cases, then I think it might be helpful to have this.
There was a problem hiding this comment.
I need to retest - we have a recent change when the product team added a native wait functionality, but it's not clear how much time we'll still spend on waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When creating an online table from the big Delta table, waiting for full sync could take too long time, and creation timeouts. The new
no_waitflag allows to skip wait for online table creation.It would be useful to merge #4048 as well
Tests
make testrun locallydocs/folderinternal/acceptance