Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Add StructToSchema for Plugin Framework #3928
[Internal] Add StructToSchema for Plugin Framework #3928
Changes from 1 commit
fd472ac
de9c989
6f1490e
da0c32a
83fced3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then on line 83 we use this
value
instead offield.Value
. This means that pointers always receive consistent treatment as if they were not pointers from the perspective of schema calculation. It's basically the equivalent to lines 17-20.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, I think for the
value
field, it actually is a bit more complex than that. I triedfield.Value.Elem()
but that gave me an error for "zero value" when I dovalue.Interface()
, so I ended up usingreflect.New
to create a new instanceThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these
default
cases, these are always types defined in the Go SDK right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes kind of, these will the nested structs and they will be in the same form as in the gosdk but they'll still live in the tf_sdk package.
The primitive fields nested inside of these structs will still use the tf types