Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] don't update databricks_metastore during creation if not required #3783

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Jul 17, 2024

Changes

  • don't update databricks_metastore during creation if not required. This was previously done for account-level provider. Extend this to workspace-level provider

Tests

  • make test run locally
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners July 17, 2024 07:51
@nkvuong nkvuong requested review from hectorcast-db and removed request for a team July 17, 2024 07:51
@nkvuong nkvuong force-pushed the fix/metastore-empty-update branch from fc98a9b to 0844b74 Compare July 18, 2024 09:02
@alexott alexott added this pull request to the merge queue Jul 20, 2024
Merged via the queue into main with commit d58f89f Jul 20, 2024
7 checks passed
@alexott alexott deleted the fix/metastore-empty-update branch July 20, 2024 06:07
tanmay-db added a commit that referenced this pull request Jul 23, 2024
### Bug Fixes

 * Fixed reading of permissions for SQL objects ([#3800](#3800)).
 * don't update `databricks_metastore` during creation if not required ([#3783](#3783)).

### Documentation

 * Clarified schedule block in `databricks_job` ([#3805](#3805)).
 * Use correct names for isolation mode for storage credentials and external locations ([#3804](#3804)).

### Internal Changes

 * Refactored `databricks_zones` and `databricks_spark_versions` data sources to Go SDK ([#3687](#3687)).

### Exporter

 * Add support for exporting of Lakeview dashboards ([#3779](#3779)).
github-merge-queue bot pushed a commit that referenced this pull request Jul 24, 2024
## 1.49.1

### Bug Fixes
* Fixed reading of permissions for SQL objects
([#3800](#3800)).
* don't update `databricks_metastore` during creation if not required
([#3783](#3783)).

### Documentation
* Clarified schedule block in `databricks_job`
([#3805](#3805)).
* Use correct names for isolation mode for storage credentials and
external locations
([#3804](#3804)).
* Fix incomplete note in databricks_workspace_binding resource
([#3806](#3806))

### Internal Changes
* Refactored `databricks_zones` and `databricks_spark_versions` data
sources to Go SDK
([#3687](#3687)).

### Exporter
* Add support for exporting of Lakeview dashboards
([#3779](#3779)).
* Adding more retries for SCIM API calls
([#3807](#3807))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants