[Feature] Added support to use protocol version 6 provider server for SDK plugin #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
requested review from
hectorcast-db,
mgyucht,
edwardfeng-db and
renaudhartert-db
and removed request for
a team and
hectorcast-db
There was a problem hiding this comment.
@tanmay-db, I just left a few comments mostly about how I think we can slightly improve the code's readability. These are optional so please feel free to ignore them.
edwardfeng-db
approved these changes
Jul 4, 2024
|
Yes, I will be addressing @renaudhartert-db's comments, just wanted to check if any core change needs to be updated since there are some conflicts (and this branch lags main branch so more conflicts) so I planned to address them simultaneously. |
tanmay-db
changed the title
|
Hi Team, catching up back on this PR. Comments have been addressed, waiting for #3780 to merge before merging this. |
5 tasks
tanmay-db
added a commit
that referenced
this pull request
Jul 17, 2024
#3780) ## Changes <!-- Summary of your changes that are easy to understand --> Rebase the Plugin Framework branch to latest main + resolve conflicts: 9e8fd30 This needs to be merged before #3719 can be merged. Rebasing the PR over main will lead to many commits/changes so separating them in this PR. ## Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> Unit tests - [ ] `make test` run locally - [ ] relevant change in `docs/` folder - [ ] covered with integration tests in `internal/acceptance` - [ ] relevant acceptance tests are passing - [ ] using Go SDK --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: vuong-nguyen <[email protected]> Co-authored-by: Alex Moschos <[email protected]> Co-authored-by: hectorcast-db <[email protected]> Co-authored-by: Aleksandar Dragojević <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Ott <[email protected]> Co-authored-by: Karol <[email protected]> Co-authored-by: touchida <[email protected]> Co-authored-by: Miles Yucht <[email protected]> Co-authored-by: Pieter Noordhuis <[email protected]> Co-authored-by: mkubicek <[email protected]> Co-authored-by: Renaud Hartert <[email protected]> Co-authored-by: Divyansh Vijayvergia <[email protected]>
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
…r SDK plugin (#3862) ## Changes <!-- Summary of your changes that are easy to understand --> Merging #3719 in main branch before release. ## Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> Nightly tests are running... - [ ] `make test` run locally - [ ] relevant change in `docs/` folder - [ ] covered with integration tests in `internal/acceptance` - [ ] relevant acceptance tests are passing - [ ] using Go SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Upgrade SDK plugin to use protocol version 6 as this will be used further for introducing plugin framework. We need to mux them (i.e. support both sdkv2 and plugin framework) until all resources are migrated to plugin framework.
Reference for PR on main branch: #3714, this PR against the main branch will be used to get the binary for testing with data team.
Tests
All Unit and Integration test passed.
make testrun locallydocs/folderinternal/acceptance