-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix model serving resource #3690
Conversation
@mgyucht @alexott @tanmay-db @hectorcast-db I don't have access to the integration tests, so can someone let me know if they're passing or not? Locally when I make the provider, the resources seem to be working fine, except for the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
=======================================
Coverage ? 81.59%
=======================================
Files ? 196
Lines ? 19699
Branches ? 0
=======================================
Hits ? 16074
Misses ? 2668
Partials ? 957
|
@alexott I have a theory the EM functionality broke with this commit, since the functionality has been broken since version |
Triggered integration tests for this |
Synced offline about integration test failures |
@edwardfeng-db looks like the PTP integration test is now passing. The EM test is still failing but that's because of the underlying Go SDK methods for create/wait that are causing this issue where the EM endpoint is being created, but the status is not being fetched correctly by the wait method. How can we fix that? @alexott @mgyucht @hectorcast-db @tanmay-db ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small questions I'd like to confirm before moving forward, otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on our discussion offline. Later, once model serving endpoints support updating the auto capture configuration without the config needing to be disabled, we can remove ForceNew from those fields and allow them to be updated.
## Changes This includes a fix for model serving endpoints. See databricks/terraform-provider-databricks#3690. ## Tests n/a
Changes
This PR fixes the provisioned throughput (PTP), external model (EM), and inference tables journeys via Terraform.
We also remove invalid validation checks and planned invalid checks. We do not add new checks since the source-of-truth should be left to the API backend, which will throw an informative error as necessary when invalid parameters are provided.
Should resolve #3676.
Tests
We add new acceptance tests to cover the different endpoint types that can be created.
make test
run locallydocs/
folderinternal/acceptance