[Internal] Refactored databricks_zones and databricks_spark_versions data sources to Go SDK
#3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkvuong
force-pushed
the
refactor/data_zones_spark
branch
from
6eff9c9 to
dd78ab8
Compare
alexott
approved these changes
Jul 2, 2024
tanmay-db
approved these changes
Jul 18, 2024
alexott
changed the title
databricks_zones and databricks_spark_versions data sources to Go SDKdatabricks_zones and databricks_spark_versions data sources to Go SDK
tanmay-db
added a commit
that referenced
this pull request
Jul 23, 2024
### Bug Fixes * Fixed reading of permissions for SQL objects ([#3800](#3800)). * don't update `databricks_metastore` during creation if not required ([#3783](#3783)). ### Documentation * Clarified schedule block in `databricks_job` ([#3805](#3805)). * Use correct names for isolation mode for storage credentials and external locations ([#3804](#3804)). ### Internal Changes * Refactored `databricks_zones` and `databricks_spark_versions` data sources to Go SDK ([#3687](#3687)). ### Exporter * Add support for exporting of Lakeview dashboards ([#3779](#3779)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
## 1.49.1 ### Bug Fixes * Fixed reading of permissions for SQL objects ([#3800](#3800)). * don't update `databricks_metastore` during creation if not required ([#3783](#3783)). ### Documentation * Clarified schedule block in `databricks_job` ([#3805](#3805)). * Use correct names for isolation mode for storage credentials and external locations ([#3804](#3804)). * Fix incomplete note in databricks_workspace_binding resource ([#3806](#3806)) ### Internal Changes * Refactored `databricks_zones` and `databricks_spark_versions` data sources to Go SDK ([#3687](#3687)). ### Exporter * Add support for exporting of Lakeview dashboards ([#3779](#3779)). * Adding more retries for SCIM API calls ([#3807](#3807))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LatestSparkVersionOrDefaultnow returns 11.3 LTS, as 7.3 LTS is deprecateddatabricks_zonesto Go SDKdatabricks_spark_versionsto Go SDK. This refactoring require one additional change toresource.go:WorkspaceDataWithCustomizeFuncto allow customization of the data source schemaLatestSparkVersionOrDefaultto a Go SDK method, which requires changing existing structs in Terraform provider to equivalent in Go SDK (clusters.SparkVersionsListtocompute.GetSparkVersionsResponse, etc.)Tests
make testrun locallyinternal/acceptance