Only suppress diff for run_if when it is ALL_SUCCESS
#3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
requested review from
mgyucht
and removed request for
a team and
mgyucht
|
Are integration tests passing? |
|
Integration tests are OK. The tests that are failing are unrelated to the change are also failing on main. |
shreyas-goenka
changed the title
run_if when it is ALL_SUCCESS
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces the
SetSuppressDiffWithDefaultwhich allows us to suppress diff in one of the most common cases. The first use of it is forrun_if.When a
run_ifis not defined for a task, the platform assigns it a default ofALL_SUCCESS. This PR fixes the suppress diff behaviour to only suppress the diff if the platform returns the default value, and not suppress it in all cases.This PR treats one of the symptoms of job tasks being reordered during diff computation, and tasks that do not have a run_if defined ending up with one in the final job.
Tests
Unit tests and manually. Task reordering during diff computation no longer incorrectly sets run_if.