Skip to content

Commit

Permalink
updated for some testing and minor edits
Browse files Browse the repository at this point in the history
  • Loading branch information
nathanknox committed Mar 8, 2023
1 parent d1e22f8 commit a5a40b6
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 3 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions examples/test_azure_uc_data_exfiltration_protection/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ This Terraform configuration is an implementation of the above blog post.
Note: the firewall rules deviate slightly in that outbound traffic from the firewall is allowed to Databricks resources instead of specifying Databricks worker subnets.
This is to simplify outbound routing in the event that multiple `spoke`s are desired.

Additionally, note that Unity Catalog has been included in this template in order to help modernize the architecture to current standards.

This guide is provided as-is and you can use this guide as the basis for your custom Terraform module.

It uses the following variables in configurations:
Expand Down
2 changes: 0 additions & 2 deletions examples/test_azure_uc_data_exfiltration_protection/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ resource "azurerm_virtual_network" "this" {
}

module "spoke_vnet" {
# TODO: Get rid of redundant variables - source them from `id`s or something
# TODO: Add Routes for service tags to the route table
source = "../../modules/azure_spoke_vnet"
project_name = var.project_name
location = azurerm_virtual_network.this.location
Expand Down
8 changes: 7 additions & 1 deletion modules/azure_uc/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@ locals {
subscription_id = regex(local.resource_regex, var.resource_group_id)[0]
resource_group = regex(local.resource_regex, var.resource_group_id)[1]
tenant_id = data.azurerm_client_config.current.tenant_id
prefix = replace(replace(lower(data.azurerm_resource_group.this.name), "rg", ""), "-", "")
prefix = replace(replace(lower("${data.azurerm_resource_group.this.name}${random_string.naming.result}"), "rg", ""), "-", "")
}

resource "random_string" "naming" {
special = false
upper = false
length = 6
}

data "azurerm_resource_group" "this" {
Expand Down

0 comments on commit a5a40b6

Please sign in to comment.