Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release fix for 2.12 #28

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Release fix for 2.12 #28

merged 6 commits into from
Sep 12, 2023

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Sep 11, 2023

Changes

This is part-1 of the two releases, this will fix 2.12 download. Version is 0.1.4. Both releases will be done on version 0.1.4

Part-2 will be of 2.13

Tests

Tried to publish to local .m2 using mvn install -Dgpg.skip=true but it's not publishing databricks-dbutils-scala, it publishes the parent. This doesn't happen while publishing on maven central. Not sure why this is happening.

Current proposal is to do a release and see if it works.

2.13 test will fail. So will have to force merge or remove them for the time being for this PR.

Copy link

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling the check means the "required check" isn't green.

As long as you can "override branch protections" on merging it will work.

@tanmay-db
Copy link
Contributor Author

@pietern Hmm, I don't see the option to override branch protection:
image

Looking if we can enable it for now.

@tanmay-db tanmay-db enabled auto-merge September 12, 2023 15:55
@tanmay-db tanmay-db disabled auto-merge September 12, 2023 15:56
@tanmay-db
Copy link
Contributor Author

No, I don't have permission -- settings tab isn't visible.
image

@tanmay-db tanmay-db added this pull request to the merge queue Sep 12, 2023
Merged via the queue into databricks:main with commit d5fdd39 Sep 12, 2023
3 checks passed
@tanmay-db tanmay-db deleted the fix-release-2_12 branch September 12, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants