Adding a python http_request wrapper to create external tools #28
Conversation
sunishsheth2009
force-pushed
the
sunish-external-tools-http
branch
3 times, most recently
from
b5e0119 to
947dc7d
Compare
Signed-off-by: Sunish Sheth <[email protected]>
sunishsheth2009
force-pushed
the
sunish-external-tools-http
branch
from
947dc7d to
d887b79
Compare
|
|
||
|
|
||
| @experimental | ||
| def http_request( |
There was a problem hiding this comment.
We should think about the module and API name a little more, maybe something like databricks_ai_bridge.external_tools.http_request? Or even databricks_ai_bridge.external_tools.request? Just thinking about how this looks in code where you might mix this with generic requests.request calls to some public APIs
There was a problem hiding this comment.
Another option is databricks_ai_bridge.uc_connections.http_request - I know we wanna present our product as external tools but what we're actually using is the UC connection to make an HTTP request in the process of defining a tool, ratehr than using a tool itself
| @@ -0,0 +1,65 @@ | |||
| import inspect | |||
There was a problem hiding this comment.
Are there tests for these annotations that we should also include + include a backlink to the OSS MLflow code (I'm guessing) that we copied from?
| params: Optional[Dict[str, Any]] = None, | ||
| ) -> requests.Response: | ||
| """ | ||
| Makes an HTTP request to an external function through the Databricks Workspace. |
There was a problem hiding this comment.
| Makes an HTTP request to an external function through the Databricks Workspace. | |
| Makes an HTTP request to a remote API using authentication from a Unity Catalog HTTP connection. |
There was a problem hiding this comment.
A few comments but mostly looks great, thanks @sunishsheth2009 !
Adding a python http_request wrapper to create external tools