Inline langchain-databricks components #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
|
@prithvikannan are we considering porting over the integration tests? I understand that's more complicated since they have their own CI/CD system |
leonbi100
reviewed
Dec 6, 2024
| @@ -1,11 +1,8 @@ | |||
| # Import modules from langchain-databricks | |||
There was a problem hiding this comment.
Are we going to remove langchain-databricks as a dependency from the pyproject.toml file?
There was a problem hiding this comment.
good callout, just updated.
There was a problem hiding this comment.
I think they're some new test issues with that change could you take a look?
yes we do plan to. this PR is just the unit tests, but we will move integration tests next. |
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Signed-off-by: Prithvi Kannan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline ChatDatabricks, DatabricksEmbeddings, and DatabricksVectorSearch from
langchain-databrickspackage and their corresponding unit tests.Remove
langchain-databricksas a dependency fordatabricks-langchain.