Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Disabled the shrink_scalar optimization for cast expressions during the resolve procedure args #17119

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Dec 26, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Explicit casts might be present to ensure the type of a procedure parameter conforms to an expected type. Simplifying these away might lead to procedure call failures.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason TCeason marked this pull request as draft December 26, 2024 03:26
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 26, 2024
@TCeason TCeason force-pushed the procedure_no_shrink_arg branch from d7eba73 to 3f2f29d Compare December 26, 2024 03:27
@sundy-li
Copy link
Member

try fix this with modify of


    fn try_fold_constant<Index: ColumnIndex>(
        &self,
        expr: &EExpr<Index>,
        enable_shrink: bool
    )

@TCeason TCeason force-pushed the procedure_no_shrink_arg branch from 3f2f29d to ac85fb8 Compare December 26, 2024 03:40
@BohuTANG BohuTANG added the ci-benchmark Benchmark: run all test label Dec 26, 2024
@BohuTANG
Copy link
Member

Using this PR as a benchmark check (unrelated to PR changes).

Copy link
Contributor

Docker Image for PR

  • tag: pr-17119-1a28914-1735196821

note: this image tag is only available for internal use,
please check the internal doc for more details.

@TCeason TCeason force-pushed the procedure_no_shrink_arg branch from ac85fb8 to a808187 Compare December 26, 2024 10:13
@TCeason TCeason marked this pull request as ready for review December 26, 2024 10:13
@sundy-li sundy-li added ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits and removed ci-benchmark Benchmark: run all test labels Dec 27, 2024
Copy link
Contributor

Docker Image for PR

  • tag: pr-17119-362b0ba-1735270702

note: this image tag is only available for internal use,
please check the internal doc for more details.

@BohuTANG BohuTANG merged commit cce8c74 into databendlabs:main Dec 27, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants