Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (v1.2.636-rc8.1) disable unprefixed_malloc_on_supported_platforms #17062

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Dec 17, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Disable (remove) cargo feature tikv-jemalloc-sys/unprefixed_malloc_on_supported_platforms to prevent lz4-sys from using jemalloc's calloc, as significant performance regressions were observed in the flight RPC compression between version 636 and version 307.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - use existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

disable(remove) cargo feature
`tikv-jemalloc-sys/unprefixed_malloc_on_supported_platforms`
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 17, 2024
@dantengsky dantengsky marked this pull request as ready for review December 17, 2024 05:32
@dantengsky dantengsky merged commit 0fe1d11 into databendlabs:release/v1.2.636-rc8.1 Dec 17, 2024
73 checks passed
@dantengsky dantengsky added the ci-cloud Build docker image for cloud test label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cloud Build docker image for cloud test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant