Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable unprefixed_malloc_on_supported_platforms #17061

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: disable unprefixed_malloc_on_supported_platforms #17061

wants to merge 1 commit into from

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Dec 17, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

DO NOT MERGE:

Disable (remove) cargo feature tikv-jemalloc-sys/unprefixed_malloc_on_supported_platforms to prevent C libs linking with jemalloc. Performance regressions have been observed in version 636. Checking the impacts on the current main branch.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - tweak crate feature

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): tweak crate feature

This change is Reviewable

@dantengsky
chore: disable unprefixed_malloc_on_supported_platforms
6d0cf4b 
disable(remove) cargo feature
`tikv-jemalloc-sys/unprefixed_malloc_on_supported_platforms`
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 17, 2024
@dantengsky dantengsky added the ci-benchmark Benchmark: run all test label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17061-f4f6d8c-1734405566

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@dantengsky dantengsky added ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits ci-benchmark-load Benchmark: run data load test and removed ci-benchmark Benchmark: run all test labels Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17061-4165b64-1734411723

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17061-4165b64-1734411748

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@sundy-li
Copy link
Member

should we use no-default-features ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits ci-benchmark-load Benchmark: run data load test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantengsky @sundy-li