refactor: optimize query system.tables when query single table #16869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCeason
force-pushed
the
list_ownership
branch
3 times, most recently
from
58caec1 to
9e8ef8b
Compare
TCeason
changed the title
github-actions
bot
added
the
pr-refactor
TCeason
force-pushed
the
list_ownership
branch
from
9e8ef8b to
6aa63b9
Compare
Docker Image for PR
|
ClickBench Report |
TCeason
force-pushed
the
list_ownership
branch
from
6aa63b9 to
855a244
Compare
drmingdrmer
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @b41sh)
b41sh
approved these changes
Nov 19, 2024
TCeason
added a commit
to TCeason/datafuse
that referenced
this pull request
Dec 6, 2024
Metadata query performance has regressed in some cases. Suggest reverting to resolve quickly and fix properly next week.
TCeason
added a commit
to TCeason/datafuse
that referenced
this pull request
Dec 6, 2024
Metadata query performance has regressed in some cases. Suggest reverting to resolve quickly and fix properly next week.
TCeason
added a commit
to TCeason/datafuse
that referenced
this pull request
Dec 9, 2024
…endlabs#16869) optimize: optimize query system.tables when query single table
TCeason
added a commit
to TCeason/datafuse
that referenced
this pull request
Dec 9, 2024
…endlabs#16869) optimize: optimize query system.tables when query single table
TCeason
added a commit
to TCeason/datafuse
that referenced
this pull request
Dec 9, 2024
…endlabs#16869) optimize: optimize query system.tables when query single table
TCeason
added a commit
to TCeason/datafuse
that referenced
this pull request
Dec 10, 2024
…endlabs#16869) optimize: optimize query system.tables when query single table
BohuTANG
pushed a commit
that referenced
this pull request
Dec 10, 2024
… (#17021) optimize: optimize query system.tables when query single table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
moved SYSTEM_TABLES_ALLOW_LIST to src/meta/app/src/principal/user_grant.rs. I also refactored the get_visibility_checker function and added a new parameter: ignore_ownership.
The purpose of this parameter is to optimize the performance of querying table information from system.tables. When this parameter is set, we can skip listing all ownerships and directly fetch a single ownership object, then perform only one get operation, thus reducing query time. In short, this change aims to improve the efficiency of querying table information from system.tables by avoiding unnecessary operations on the list of ownerships.
Tests
Type of change
This change is