refactor: change blocking pruning process to non-blocking channel #16718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
2 tasks
dqhl76
added
ci-benchmark-cloud
Docker Image for PR
|
dqhl76
added
the
ci-benchmark-cloud
Docker Image for PR
|
dqhl76
removed
the
ci-benchmark-cloud
Docker Image for PR
|
zhang2014
reviewed
Nov 1, 2024
src/query/storages/fuse/src/operations/read/block_partition_receiver_source.rs
Outdated
Show resolved
Hide resolved
zhang2014
reviewed
Nov 1, 2024
zhang2014
reviewed
Nov 1, 2024
zhang2014
approved these changes
Nov 1, 2024
|
logic test time out. |
zhang2014
added
ci-benchmark
Docker Image for PR
|
dqhl76
added
ci-benchmark
Docker Image for PR
|
sundy-li
approved these changes
Nov 1, 2024
xudong963
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Initialize the refactoring work of #16626
ReadNativeDataSourceandReadParquetDataSourcewithReadNativeDataTransformandReadParquetDataTransformRead{Native|Parquet}DataSource's generating work toBlockPartitionReceiverSource(used to receive meta from a channel), andBlockPartitionSource(used to get meta fromStealablePartitions)Change the original ParquetSource and NativeSource into a Sourcer responsible only for receiving data and a Transformer responsible only for reading data:
Tests
Type of change
This change is