Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: limit stage name to plain_identifier #16522

Merged
merged 2 commits into from
Sep 26, 2024
Merged

feat: limit stage name to plain_identifier #16522

merged 2 commits into from
Sep 26, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Sep 25, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix #16521

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 25, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 25, 2024
@dosubot dosubot bot added the A-query Area: databend query label Sep 25, 2024
@youngsofun youngsofun changed the title feat: list stage name to plain_identifier. feat: limit stage name to plain_identifier. Sep 25, 2024
@andylokandy andylokandy changed the title feat: limit stage name to plain_identifier. feat: limit stage name to plain_identifier Sep 25, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 26, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2024
@youngsofun youngsofun added this pull request to the merge queue Sep 26, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 26, 2024
@BohuTANG BohuTANG merged commit bb92fdc into databendlabs:main Sep 26, 2024
85 checks passed
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andylokandy andylokandy andylokandy approved these changes

@sundy-li sundy-li Awaiting requested review from sundy-li

@flaneur2020 flaneur2020 Awaiting requested review from flaneur2020

Assignees
No one assigned
Labels
A-query Area: databend query lgtm This PR has been approved by a maintainer pr-feature this PR introduces a new feature to the codebase size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: stage created with quoted name can not be corretly refereced with @<stage_name>
3 participants
@youngsofun @andylokandy @BohuTANG