Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog): ignore error when listing databases #16514

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Sep 25, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR addresses a potential error in the "list databases" functionality, which could disrupt the display of all databases.
Like say we removed SHARE, the error will:
image

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - This change does not affect the core logic of listing databases; it simply ignores certain errors when listing.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 25, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 25, 2024
@dosubot dosubot bot added the A-query Area: databend query label Sep 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 25, 2024
@BohuTANG BohuTANG merged commit 9c4735a into databendlabs:main Sep 25, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query lgtm This PR has been approved by a maintainer pr-feature this PR introduces a new feature to the codebase size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants