Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add create or replace virtual column support #14649

Merged
merged 1 commit into from
Feb 8, 2024
Merged

feat: add create or replace virtual column support #14649

merged 1 commit into from
Feb 8, 2024

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented Feb 8, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat: add create or replace virtual column support

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@lichuang lichuang requested review from drmingdrmer and b41sh February 8, 2024 12:30
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Feb 8, 2024
drmingdrmer
drmingdrmer approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 11 files reviewed, all discussions resolved (waiting on @b41sh)

@BohuTANG BohuTANG merged commit 4112e06 into databendlabs:main Feb 8, 2024
73 of 74 checks passed
@lichuang
Copy link
Contributor Author

lichuang commented Feb 9, 2024

@soyeric128

@BohuTANG BohuTANG mentioned this pull request Feb 9, 2024
Closed
14 tasks
@lichuang lichuang deleted the replace_or_create_virtual_column branch March 7, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

@drmingdrmer drmingdrmer drmingdrmer approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: add create or replace virtual column support
4 participants
@lichuang @drmingdrmer @b41sh @BohuTANG