refactor: Add KVPbApi::list_pb(), simplify UdfMgr::get_udfs()
#14623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
41-list-udf
branch
from
4de7d8f to
ce4b569
Compare
`KVPbApi::list_pb()` lists key value pairs by a prefix `DirName<K>`, and decodes key back to `kvapi::Key` and values back to `kvapi::Key::ValueType`. `UdfMgr::get_udfs()` is simplified by using `list_pb()`.
drmingdrmer
force-pushed
the
41-list-udf
branch
from
ce4b569 to
338601f
Compare
drmingdrmer
commented
Feb 6, 2024
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @everpcpc, @lichuang, and @sundy-li)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: Add
KVPbApi::list_pb(), simplifyUdfMgr::get_udfs()KVPbApi::list_pb()lists key value pairs by a prefixDirName<K>, anddecodes key back to
kvapi::Keyand values back tokvapi::Key::ValueType.UdfMgr::get_udfs()is simplified by usinglist_pb().Changelog
Related Issues
This change is