Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): improve hash join code #14614

Merged
merged 6 commits into from
Feb 7, 2024
Merged

chore(query): improve hash join code #14614

merged 6 commits into from
Feb 7, 2024

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Feb 5, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Improve hash join code to make it more clear, inner join and left join get slight performance improvements.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Covered by existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 5, 2024
@Dousir9 Dousir9 marked this pull request as ready for review February 6, 2024 09:48
@Dousir9 Dousir9 requested review from leiysky and xudong963 February 6, 2024 09:48
@BohuTANG BohuTANG added the ci-benchmark Benchmark: run all test label Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Docker Image for PR

  • tag: pr-14614-775ce9f

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Dousir9 Dousir9 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Docker Image for PR

  • tag: pr-14614-4be6e76

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024 •
edited by Dousir9
Loading

ClickBench Report\n*

hits: https://benchmark.databend.rs/clickbench/pr/14614/7802504312/hits.html
internal: https://benchmark.databend.rs/clickbench/pr/14614/7802504312/internal.html
tpch: https://benchmark.databend.rs/clickbench/pr/14614/7802504312/tpch.html

@BohuTANG BohuTANG merged commit 87aaa2f into databendlabs:main Feb 7, 2024
82 checks passed
@Dousir9 Dousir9 deleted the improve_hash_join_code branch February 7, 2024 02:18
yufan022 pushed a commit to yufan022/databend that referenced this pull request Apr 25, 2024
@Dousir9 @yufan022
chore(query): improve hash join code (databendlabs#14614)
840796b 
* improve hash join code

* fix: from left single join to inner join

* chore: improve left join

* fix: right single to inner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963 xudong963 approved these changes

@leiysky leiysky Awaiting requested review from leiysky

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dousir9 @xudong963 @BohuTANG