Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): modify alter table column parser #14282

Closed
wants to merge 1 commit into from

Conversation

KKould
Copy link

@KKould KKould commented Jan 9, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

support: ADD COLUMN -> ADD [ COLUMN ]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 9, 2024
@KKould KKould changed the title feat(parser): modify alter table column parser feat(query): modify alter table column parser Jan 9, 2024
@sundy-li
Copy link
Member

Cause ambiguity because we already have: ALTER TABLE t09_0014 DROP CLUSTER KEY

@KKould KKould closed this Jan 10, 2024
@sundy-li
Copy link
Member

sundy-li commented Jan 10, 2024

@KKould You can reorder the parser #drop_table_cluster_key before #drop_column, I think it may work.

And execute env REGENERATE_GOLDENFILES=1 cargo test in ast crate to regenerate the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants