Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use raw sql as task SQL instead of pretty one #14281

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

ZhiHanZ
Copy link
Collaborator

@ZhiHanZ ZhiHanZ commented Jan 9, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Use raw formatted SQL instead of prettied one.
Previous, task SQL used the pretty_statement function and generate prettified SQL for further cloud service execution, but it seems like there are some SQL may parse in different way and unable to execute anymore. for example

copy into @stream_stage from (
        SELECT
            CASE
                WHEN (RAND() * 10)::INT % 4 = 0 THEN 'a'
                WHEN (RAND() * 10)::INT % 4 = 1 THEN 'b'
                WHEN (RAND() * 10)::INT % 4 = 2 THEN 'c'
                ELSE 'd'
            END AS level
        FROM numbers(500000)
    ) FILE_FORMAT = (
        TYPE = PARQUET
    );

its pretty formatted string is

COPY INTO Stage("stream_stage")
FROM (
    SELECT CASE
        WHEN (((RAND() * 10)::Int32 % 4) = 0) THEN 'a',
        WHEN (((RAND() * 10)::Int32 % 4) = 1) THEN 'b',
        WHEN (((RAND() * 10)::Int32 % 4) = 2) THEN 'c',
        ELSE 'd'
    END AS level
    FROM numbers(500000)
)
FILE_FORMAT = (
    type = "PARQUET"
)
SINGLE = false;

which is unable to execute

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 9, 2024
@ZhiHanZ
Copy link
Collaborator Author

ZhiHanZ commented Jan 9, 2024

github down, ci cannot work...

@ZhiHanZ ZhiHanZ added this pull request to the merge queue Jan 10, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 10, 2024
@BohuTANG BohuTANG merged commit 91f4930 into databendlabs:main Jan 10, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants