refactor: common-exception crate should be independent of meta-types
#14275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `databend-common-exception` crate, which is a general-purpose library, should not have a dependency on the business-specific `databend-common-meta-types` crate. With this commit, we've relocated the conversion logic for transforming `Meta**` errors into `ErrorCode`. These conversions are now handled within the meta-service related crates: `databend-common-meta-types` and `databend-common-sto-error`.
github-actions
bot
added
the
pr-refactor
BohuTANG
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor:
common-exceptioncrate should be independent ofmeta-typesThe
databend-common-exceptioncrate, which is a general-purposelibrary, should not have a dependency on the business-specific
databend-common-meta-typescrate.With this commit, we've relocated the conversion logic for transforming
Meta**errors intoErrorCode. These conversions are now handledwithin the meta-service related crates:
databend-common-meta-typesanddatabend-common-sto-error.Changelog
Related Issues
This change is