refactor: Replace KVApi::get() and KVApi::mget_kv() with get_kv_stream()
#14255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
29-mget-stream
branch
5 times, most recently
from
6111260 to
bfa7591
Compare
…stream()` - **Compatibility Update**: Starting with this version of databend-query, the minimum required version of the meta-service has been updated from 1.1.32 to 1.2.226 as of 2023-11-26. Note that the min compatible is 1.2.163 but `[1.2.163, 1.2.226)` are removed from release download, due to some known bugs found in these versions. - The `KVApi::get()` and `KVApi::mget_kv()` functions, which previously performed similar operations, have been merged into `get_kv_stream()`, which returns a stream of key-value pairs. In trait `KVApi`, `get_kv()` and `mget_kv()` are replaced with default implementation for backward compatibility. Additionally, we have introduced a new error type, `IncompleteStream`, to handle cases where the stream does not complete as expected.
drmingdrmer
force-pushed
the
29-mget-stream
branch
from
bfa7591 to
e7998d9
Compare
drmingdrmer
commented
Jan 7, 2024
There was a problem hiding this comment.
Reviewed 16 of 17 files at r1.
Reviewable status: 16 of 17 files reviewed, all discussions resolved (waiting on @lichuang)
drmingdrmer
commented
Jan 7, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lichuang)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: Replace
KVApi::get()andKVApi::mget_kv()withget_kv_stream()Compatibility Update: Starting with this version of
databend-query, the minimum required version of the meta-service has
been updated from 1.1.32 to 1.2.226 as of 2023-11-26.
Note that the min compatible is 1.2.163 but
[1.2.163, 1.2.226)areremoved from release download, due to some known bugs found in these
versions.
The
KVApi::get()andKVApi::mget_kv()functions, which previouslyperformed similar operations, have been merged into
get_kv_stream(),which returns a stream of key-value pairs.
In trait
KVApi,get_kv()andmget_kv()are replaced with defaultimplementation for backward compatibility.
Additionally, we have introduced a new error type,
IncompleteStream,to handle cases where the stream does not complete as expected.
Changelog
Related Issues
This change is