Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto refresh ReadOnlyAttach-ed table schema #14241

Merged
merged 14 commits into from
Jan 10, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Jan 5, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

auto-refresh ReadOnlyAttach-ed table schema.

  • introduce the new Trait TableInfoRefresher

    Table engines may register their impls of TableInfoRefresher to storage factory

  • fuse table engine's impl of TableInfoRefresher will refresh schema by syncing the latest schema from the attached storage, if the table is created in the "attach read-only" way.

  • during alter table add/remove column, a new table snapshot will be generated and kept in the object storage

    so that the latest schema could be fetched without accessing the meta server (which is infeasible if the table is read-only attached).

    related test cases are tweaked accordingly.

Fixes #13559

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 5, 2024
@dantengsky dantengsky marked this pull request as ready for review January 9, 2024 07:07
@BohuTANG BohuTANG merged commit f725047 into databendlabs:main Jan 10, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: use fresh schema while scanning READ_ONLY ATTACH Table
2 participants