Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): better handling of nullable columns during filter execution #14197

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Jan 2, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Solve the problem in #14190

Benchmark TPC-H SF100 External Parquet:

query main pr
Q1 12.7 11.8
Q3 5.1 4.2
Q4 3.6 3.2
Q6 5.3 4.2
Q7 5.6 4.6
Q10 7.9 6.2
Q12 7.9 6.3
Q14 4.1 3.5
Q15 7.0 5.9
Q19 11.3 9.6
Q20 17.3 15.5
Q21 8.2 6.7

TPC-H SF100 External Parquet Q19 FlameGraph before:
截屏2024-01-02 13 53 09
TPC-H SF100 External Parquet Q19 FlameGraph after:
截屏2024-01-02 13 53 42

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Covered by existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 2, 2024
@Dousir9 Dousir9 requested a review from sundy-li January 2, 2024 07:13
@Dousir9 Dousir9 marked this pull request as ready for review January 2, 2024 07:13
@sundy-li sundy-li added this pull request to the merge queue Jan 2, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 2, 2024
@BohuTANG BohuTANG merged commit 6b8fd7f into databendlabs:main Jan 2, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants