Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): refresh hook does not return an error #14194

Merged
merged 6 commits into from
Jan 2, 2024
Merged

chore(query): refresh hook does not return an error #14194

merged 6 commits into from
Jan 2, 2024

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Jan 1, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • refresh hook does not return an error
  • build virtual column refresh plan only when user have created it.

Fixes #14192

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Covered by existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested review from sundy-li and TCeason January 1, 2024 17:30
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 1, 2024
TCeason
TCeason approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need fix the ee test

@BohuTANG
Copy link
Member

BohuTANG commented Jan 2, 2024

Does the aggregating index refresh has this issue? @ariesdevil

@ariesdevil
Copy link
Contributor

Does the aggregating index refresh has this issue? @ariesdevil↳

I'm checking

@b41sh b41sh changed the title fix(query): fix hook refresh virtual columns without license chore(query): refresh hook do not return error Jan 2, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 2, 2024
@b41sh b41sh changed the title chore(query): refresh hook do not return error chore(query): refresh hook does not return an error Jan 2, 2024
@BohuTANG BohuTANG merged commit 98935c1 into databendlabs:main Jan 2, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCeason TCeason TCeason approved these changes

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: OSS failed to execute 'bendsql --query='INSERT INTO default.t1 VALUES;' --format=csv [email protected]'
5 participants
@b41sh @BohuTANG @ariesdevil @sundy-li @TCeason