Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: integrate HeapMerger to TransformMultiSortMerge. #14065

Merged
merged 3 commits into from
Dec 25, 2023
Merged

refactor: integrate HeapMerger to TransformMultiSortMerge. #14065

merged 3 commits into from
Dec 25, 2023

Conversation

RinChanNOWWW
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW commented Dec 18, 2023 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Use HeapMerger in TransformMultiSortMerge.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - The tests are already added in history PRs.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 18, 2023
@RinChanNOWWW RinChanNOWWW force-pushed the refactor-sort branch 2 times, most recently from 2c63506 to 51df83c Compare December 21, 2023 08:31
@RinChanNOWWW RinChanNOWWW added the ci-benchmark Benchmark: run all test label Dec 21, 2023
@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review December 21, 2023 09:30
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14065-84dff98

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

cloud cloud

ClickBench Report

@sundy-li sundy-li added this pull request to the merge queue Dec 25, 2023
Merged via the queue into databendlabs:main with commit d6f7262 Dec 25, 2023
68 checks passed
@RinChanNOWWW RinChanNOWWW deleted the refactor-sort branch December 25, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@zhang2014 zhang2014 Awaiting requested review from zhang2014

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RinChanNOWWW @sundy-li @BohuTANG