Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): add explain for sync agg index #14053

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

ariesdevil
Copy link
Contributor

@ariesdevil ariesdevil commented Dec 18, 2023

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Add sqllogictests for sync aggregating index.
set enable_refresh_aggregating_index_after_write default to 1
also set enable_refresh_virtual_column_after_write to 1
cc @b41sh

Fixes #14046

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): add tests

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 18, 2023
@BohuTANG
Copy link
Member

We should:

  1. set enable_refresh_aggregating_index_after_write default to 1? It's better to allow user to disable a settings but not let them to enable it when they use, user always never know when to enable it.
  2. We also need add the introduce of SYNC to doc.

Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit b32b39c into databendlabs:main Dec 18, 2023
70 checks passed
@ariesdevil ariesdevil deleted the agg-index branch December 18, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aggregating index doesn't show in the explain
2 participants