Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add range for show settings #14049

Merged
merged 1 commit into from
Dec 18, 2023
Merged

feat: add range for show settings #14049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/query/sql/src/planner/binder/show.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ impl Binder {
) -> Result<Plan> {
let (show_limit, limit_str) = get_show_options(show_options, None);
let query = format!(
"SELECT name, value, default, level, description, type FROM system.settings {} ORDER BY name {}",
"SELECT name, value, default, `range`, level, description, type FROM system.settings {} ORDER BY name {}",
show_limit, limit_str,
);

Expand Down
4 changes: 2 additions & 2 deletions tests/sqllogictests/suites/base/06_show/06_0003_show_settings.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ SHOW SETTINGS LIKE 'enable%'
query TT
SHOW SETTINGS LIKE 'max%' LIMIT 1
----
max_block_size 65536 65536 SESSION Sets the maximum byte size of a single data block that can be read. UInt64
max_block_size 65536 65536 None SESSION Sets the maximum byte size of a single data block that can be read. UInt64

query TT
SHOW SETTINGS WHERE name='max_block_size' LIMIT 1
----
max_block_size 65536 65536 SESSION Sets the maximum byte size of a single data block that can be read. UInt64
max_block_size 65536 65536 None SESSION Sets the maximum byte size of a single data block that can be read. UInt64

statement error
SHOW SETTINGS ilike 'ff%' LIMIT 1
Expand Down
Loading