feat: Introduced MetaSpec for setting relative expiration
#14041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
drmingdrmer
force-pushed
the
41-expire-rel
branch
15 times, most recently
from
7dd80df to
80a59d7
Compare
This is a compatible change with new feature provided. - This commit introduces a new type, `MetaSpec`, which specifies content of the `KVMeta` to be stored for a key. This new type is particularly utilized in `upsert` requests to enable the setting of relative expiration times. Previously, the `KVMeta` type was used directly for this purpose. However, to avoid impacting existing storage data types, `MetaSpec` has been specifically added for use in `upsert` operations. When applying a raft-log, a `KVMeta` is built from `MetaSpec`. Designed with backward compatibility, `MetaSpec` maintains a serialized format compatible with `KVMeta`, ensuring no disruption to existing functionality. - We introduce two new types `Time` and `Interval` to reprensent serde-able time stamp and time interval. - Tests are added to ensure meta-service works correctly with API with ttl support, but databend-query does not use these API yet.
drmingdrmer
force-pushed
the
41-expire-rel
branch
from
80a59d7 to
9ce746e
Compare
drmingdrmer
commented
Dec 16, 2023
There was a problem hiding this comment.
Reviewed 13 of 27 files at r1, 13 of 13 files at r2, 5 of 5 files at r3, 1 of 1 files at r4, 18 of 18 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @drmingdrmer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
feat: Introduced
MetaSpecfor setting relative expirationThis is a compatible change with new feature provided.
This commit introduces a new type,
MetaSpec, which specifies contentof the
KVMetato be stored for a key. This new type is particularlyutilized in
upsertrequests to enable the setting of relativeexpiration times.
Previously, the
KVMetatype was used directly for this purpose.However, to avoid impacting existing storage data types,
MetaSpechasbeen specifically added for use in
upsertoperations. When applying araft-log, a
KVMetais built fromMetaSpec.Designed with backward compatibility,
MetaSpecmaintains a serializedformat compatible with
KVMeta, ensuring no disruption to existingfunctionality.
We introduce two new types
TimeandIntervalto reprensentserde-able time stamp and time interval.
Tests are added to ensure meta-service works correctly with API with
ttl support, but databend-query does not use these API yet.
Changelog
Related Issues
This change is