Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): add decimal round/truncate/ceil/floor function #14040

Merged
merged 9 commits into from
Dec 18, 2023
Merged

feat(query): add decimal round/truncate/ceil/floor function #14040

merged 9 commits into from
Dec 18, 2023

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Dec 15, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Summary about this PR

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 15, 2023
@sundy-li sundy-li changed the title feat(query): add decimal round/truncate function feat(query): add decimal round/truncate/ceil/floor function Dec 16, 2023
@sundy-li sundy-li marked this pull request as ready for review December 16, 2023 08:05
@sundy-li
Copy link
Member Author

cc @xudong963 help me check the TPCH results scale differ with pg

@BohuTANG BohuTANG added the ci-cloud Build docker image for cloud test label Dec 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14040-4d24b4c

note: this image tag is only available for internal use,
please check the internal doc for more details.

@BohuTANG BohuTANG added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Dec 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14040-4d24b4c

note: this image tag is only available for internal use,
please check the internal doc for more details.

@BohuTANG
Copy link
Member

Wizard Test Passed!

@sundy-li sundy-li added this pull request to the merge queue Dec 18, 2023
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 18, 2023
@BohuTANG BohuTANG merged commit e19d4c1 into databendlabs:main Dec 18, 2023
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963 xudong963 approved these changes

@youngsofun youngsofun youngsofun approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: round(3674.282782431427, 8) issue
4 participants
@sundy-li @BohuTANG @youngsofun @xudong963