refactor: abstract a common merger to do merge sort. #14020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
RinChanNOWWW
force-pushed
the
refactor-sort
branch
from
f3de5e2 to
749b8bf
Compare
RinChanNOWWW
force-pushed
the
refactor-sort
branch
7 times, most recently
from
fafc58a to
bc37c9e
Compare
RinChanNOWWW
force-pushed
the
refactor-sort
branch
2 times, most recently
from
904182b to
fce46a1
Compare
RinChanNOWWW
force-pushed
the
refactor-sort
branch
from
fce46a1 to
c33cca4
Compare
Docker Image for PR
|
RinChanNOWWW
force-pushed
the
refactor-sort
branch
2 times, most recently
from
186be1a to
d155cf7
Compare
RinChanNOWWW
force-pushed
the
refactor-sort
branch
from
d155cf7 to
855d977
Compare
RinChanNOWWW
force-pushed
the
refactor-sort
branch
from
eb60945 to
43b9c1c
Compare
sundy-li
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Add a
HeapMergerto do multi-way merge sort by using a binary heap.TransformSortMerge,TransformSortSpilluse this merger to do merge sort now.The integration for
TransformMultiSortMergewill be done in next PR, as there are some problems to solve. I don't want it block this PR.Tests
This change is