Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): fix count all in lambda function #13991

Merged
merged 6 commits into from
Dec 12, 2023
Merged

fix(query): fix count all in lambda function #13991

merged 6 commits into from
Dec 12, 2023

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Dec 12, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • fix count all in lambda function
  • refactor resolve lambda function as a seperate function

Closes #13975

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

This change is Reviewable

@b41sh b41sh requested review from sundy-li and ariesdevil December 12, 2023 08:41
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 12, 2023
@b41sh b41sh added this pull request to the merge queue Dec 12, 2023
@sundy-li sundy-li removed this pull request from the merge queue due to a manual request Dec 12, 2023
@sundy-li
Copy link
Member

Better to check this in resolve_aggregate_function

@sundy-li sundy-li enabled auto-merge December 12, 2023 13:13
@sundy-li sundy-li added this pull request to the merge queue Dec 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2023
@b41sh b41sh added this pull request to the merge queue Dec 12, 2023
Merged via the queue into databendlabs:main with commit 193ed56 Dec 12, 2023
70 checks passed
@b41sh b41sh deleted the fix-lambda-count branch December 12, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariesdevil ariesdevil ariesdevil approved these changes

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: lambda function using count(*) causing unable to get field named
3 participants
@b41sh @sundy-li @ariesdevil